Skip to content

plan: hints MCP call shape (#195)#201

Closed
HumanBean17 wants to merge 3 commits into
masterfrom
plan/hints-mcp-call-shape
Closed

plan: hints MCP call shape (#195)#201
HumanBean17 wants to merge 3 commits into
masterfrom
plan/hints-mcp-call-shape

Conversation

@HumanBean17
Copy link
Copy Markdown
Owner

@HumanBean17 HumanBean17 commented May 22, 2026

Summary

Planning only — no code, tests, or doc implementation in this PR (diff vs master is these two plan files only; branch rebased onto current master).

Branch: plan/hints-mcp-call-shape. Implementation follow-up: feat/hints-mcp-call-shape-195 per plan § PR-1.

Test plan

  • Rebased onto master — Files changed should show 2 plan files only
  • Review plan PR breakdown, sentinel tests, and out-of-scope guardrails
  • Confirm coordination note for in-flight DESCRIBE-HINTS-STRUCTURAL

Copy link
Copy Markdown
Owner Author

@HumanBean17 HumanBean17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

Verdict: Approve the plan docs after rebase — content is strong and aligned with the landed propose (#197). Do not merge as-is without rebasing onto current master.

What actually merges

Against current master, this PR adds only:

  • plans/PLAN-HINTS-MCP-CALL-SHAPE.md (+232)
  • plans/CURSOR-PROMPTS-HINTS-MCP-CALL-SHAPE.md (+137)

GitHub still shows 66 files / +2058 because the branch was cut before #197#199 landed (propose, bank-chat fixture, OVERRIDDEN-BY archive). Those commits are already on master — not new work here.

Before merge: rebase onto master so the PR diff and CI reflect the true two-file delta.

PR description

“Planning only — no code, tests, or doc implementation” is accurate vs current master, but the Files-changed tab is misleading until rebase. Worth a one-line note in the PR body.

Plan quality

  • Clear problem → solution (pseudo-Python neighbors(['{id}'],…) → MCP-copyable named args; issue #195 combo 1+2+6).
  • Good guardrails: no coercion / no ontology bump, HINT_MAX_RENDERED_CHARS = 250, sentinel tests + rg "neighbors\(\['".
  • Actionable file matrix and coordination with in-flight DESCRIBE-HINTS-STRUCTURAL-PROPOSE.md.
  • Aligns with landed propose/HINTS-MCP-CALL-SHAPE-PROPOSE.md.

Nits (non-blocking)

  1. Branch naming: Plan § PR-1 says implementation branch plan/hints-mcp-call-shape — same as this planning branch. Propose suggests cursor/… or feat/…; recommend feat/hints-mcp-call-shape-195 for the implementation PR.
  2. Sentinel scope: test_hint_source_no_python_bracket_ids / rg only cover mcp_hints.py + java_ontology.py; plan also edits scripts/generate_edge_navigation.py — consider extending the sentinel or documenting the exclusion.
  3. Label consistency: Plan uses PR-1; prompts use PR-HINTS-MCP-CALL-SHAPE-1 — minor.

Next steps

  1. Rebase → confirm diff is 2 files → green CI.
  2. Merge #201.
  3. Implementation: feat/hints-mcp-call-shape-195 off master, follow CURSOR-PROMPTS-HINTS-MCP-CALL-SHAPE.md § PR-HINTS-MCP-CALL-SHAPE-1.

HumanBean17 and others added 3 commits May 22, 2026 16:57
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@HumanBean17 HumanBean17 force-pushed the plan/hints-mcp-call-shape branch from 0e80a1a to b08bce1 Compare May 22, 2026 13:58
@HumanBean17 HumanBean17 deleted the plan/hints-mcp-call-shape branch May 22, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant