plan: hints MCP call shape (#195)#201
Closed
HumanBean17 wants to merge 3 commits into
Closed
Conversation
HumanBean17
commented
May 22, 2026
Owner
Author
HumanBean17
left a comment
There was a problem hiding this comment.
Review summary
Verdict: Approve the plan docs after rebase — content is strong and aligned with the landed propose (#197). Do not merge as-is without rebasing onto current master.
What actually merges
Against current master, this PR adds only:
plans/PLAN-HINTS-MCP-CALL-SHAPE.md(+232)plans/CURSOR-PROMPTS-HINTS-MCP-CALL-SHAPE.md(+137)
GitHub still shows 66 files / +2058 because the branch was cut before #197–#199 landed (propose, bank-chat fixture, OVERRIDDEN-BY archive). Those commits are already on master — not new work here.
Before merge: rebase onto master so the PR diff and CI reflect the true two-file delta.
PR description
“Planning only — no code, tests, or doc implementation” is accurate vs current master, but the Files-changed tab is misleading until rebase. Worth a one-line note in the PR body.
Plan quality
- Clear problem → solution (pseudo-Python
neighbors(['{id}'],…)→ MCP-copyable named args; issue #195 combo 1+2+6). - Good guardrails: no coercion / no ontology bump,
HINT_MAX_RENDERED_CHARS = 250, sentinel tests +rg "neighbors\(\['". - Actionable file matrix and coordination with in-flight
DESCRIBE-HINTS-STRUCTURAL-PROPOSE.md. - Aligns with landed
propose/HINTS-MCP-CALL-SHAPE-PROPOSE.md.
Nits (non-blocking)
- Branch naming: Plan § PR-1 says implementation branch
plan/hints-mcp-call-shape— same as this planning branch. Propose suggestscursor/…orfeat/…; recommendfeat/hints-mcp-call-shape-195for the implementation PR. - Sentinel scope:
test_hint_source_no_python_bracket_ids/rgonly covermcp_hints.py+java_ontology.py; plan also editsscripts/generate_edge_navigation.py— consider extending the sentinel or documenting the exclusion. - Label consistency: Plan uses PR-1; prompts use PR-HINTS-MCP-CALL-SHAPE-1 — minor.
Next steps
- Rebase → confirm diff is 2 files → green CI.
- Merge #201.
- Implementation:
feat/hints-mcp-call-shape-195offmaster, followCURSOR-PROMPTS-HINTS-MCP-CALL-SHAPE.md§ PR-HINTS-MCP-CALL-SHAPE-1.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
0e80a1a to
b08bce1
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plans/PLAN-HINTS-MCP-CALL-SHAPE.mdfor issue hints: Python-style neighbors(['id'],…) copies fail; JSON stringified ids work #195 (combo 1+2+6).plans/CURSOR-PROMPTS-HINTS-MCP-CALL-SHAPE.md.propose/HINTS-MCP-CALL-SHAPE-PROPOSE.md(already onmastervia propose: MCP-copyable hints and 500-char cap (#195) #197).Planning only — no code, tests, or doc implementation in this PR (diff vs
masteris these two plan files only; branch rebased onto currentmaster).Branch:
plan/hints-mcp-call-shape. Implementation follow-up:feat/hints-mcp-call-shape-195per plan § PR-1.Test plan
master— Files changed should show 2 plan files only